-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Alignment #157
Merged
Merged
API Alignment #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er' functions in it.
…' functions in it.
…uilder' functions in it.
…uilder' functions in it.
…'builder' functions in it.
…' functions in it.
…allback subclasses + tidying up documentation.
PR missing one of the required labels: {'bug', 'internal', 'documentation', 'breaking-change', 'new feature', 'enhancement', 'dependencies'} |
DariusIMP
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
release
Part of the next release
labels
Dec 11, 2024
DariusIMP
requested review from
oteffahi and
milyin
and removed request for
oteffahi
December 13, 2024 14:01
Merged
milyin
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but some options structures doesn't implement setters/getters.
I just changed a couple of things:
|
Merged
milyin
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
release
Part of the next release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extensively updates the Zenoh Java API.
Api modifications:
Removing all builder patterns and resolvables
We noticed this kind of API was causing confusions among Java users:
For 2 reasons:
.res()
call was often forgottenIt was decided to go for an approach similar to the C++'s bindings with Option objects, for instance:
New features introduced:
Documentation:
All the documentation was updated with examples following the new API.
Misc:
Logger refactoring
Logs can now be achieved by running for instance:
similar to other Zenoh bindings.
Packages reordering
Adding new examples
Added examples: Zping, ZPong, ZScout
Also providing argument handling to them with 'picocli'.
Encoding updates
Internal:
Missing items
ZBytes serialization and deserialization utilities, to be added in a followup PR.