Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/selector params #168

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

DariusIMP
Copy link
Member

To be merged after PR #167 .

Equivalent to eclipse-zenoh/zenoh-kotlin#333

Issue:

When sending query to "a/b/c" selector (for instance), the queryable was receiving "a/b/c?null" as selector.

Fix:

Bug caused by missing '?' null check.

Tested

Manually + added unit test

When performing a query to "a/b/c", the queryable received a selector of "a/b/c?null=". Caused by a missing null check.
@DariusIMP DariusIMP requested a review from milyin December 27, 2024 16:36
Copy link

PR missing one of the required labels: {'new feature', 'enhancement', 'breaking-change', 'bug', 'documentation', 'dependencies', 'internal'}

@DariusIMP DariusIMP added bug Something isn't working release Part of the next release internal Changes not included in the changelog and removed internal Changes not included in the changelog labels Dec 27, 2024
@J-Loudet J-Loudet merged commit 03f6446 into eclipse-zenoh:main Jan 6, 2025
10 of 11 checks passed
@DariusIMP DariusIMP deleted the fix/selector_params branch January 16, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants