Removing workflow_dispatch from android and jvm publication workflows #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariusIMP
added
bug
diogomatsubara
suggested changes
Jan 29, 2025
There was a problem hiding this comment.
I don't think we need the workflow_dispatch at all here. Both publish-android.yml and publish-jvm.yml are intended to be called from the release workflow and use the workflow_call inputs and not to be called manually via workflow_dispatch. Unless I'm missing some other use case.
DariusIMP
force-pushed
the
android_workflow
branch
from
3d4c22d to
64e0883
Compare
DariusIMP
changed the title
diogomatsubara
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.