Align version with zenoh-c (#438) #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogomatsubara
force-pushed
the
cmake-fixes-dev-1.0.0
branch
from
14dbbe2
to
3957803
Compare
* feat: Store project version in `version.txt` * fix: Add `CMakeFiles` to `.gitignore` * feat: Automate Release * fix: Remove enforce-linking-issues workflow * fix: Remove unecessary SSH passphrase/privatekey inputs * fix: Force push release branch * fix: Make build-macos need pre-build * fix: Typo in pre-build.bash path * fix: Typo in examples build path
As per eclipse-zenoh/zenoh-c#466, align how we configure zenoh CMake based projects version.
diogomatsubara
force-pushed
the
cmake-fixes-dev-1.0.0
branch
from
46eac1a
to
f8a5238
Compare
jean-roland
approved these changes
Jun 25, 2024
Mallets
reviewed
Jun 25, 2024
Mallets
approved these changes
Jun 25, 2024
diogomatsubara
force-pushed
the
cmake-fixes-dev-1.0.0
branch
from
17657e8
to
64d48b2
Compare
Mallets
approved these changes
Jun 25, 2024
|
I think f8a5238 should be reverted as Instead we could benefit from a README section similar to zenoh-c's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick changes from
mainintodev/1.0.0