Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request timeout u64 error #646

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

jean-roland
Copy link
Contributor

When requesting with a timeout value > U32MAX, zenoh pico would close the connection due to a malformed message.

Changed internal timeout field to be u64.

Bonus: Truncate budget to u32 instead of error (rust behavior alignment).

Copy link

PR missing one of the required labels: {'internal', 'enhancement', 'bug', 'documentation', 'new feature', 'breaking-change', 'dependencies'}

@jean-roland jean-roland added the bug Something isn't working label Sep 11, 2024
@OlivierHecart OlivierHecart merged commit 8a5f1bb into eclipse-zenoh:main Sep 11, 2024
53 of 54 checks passed
@jean-roland jean-roland deleted the fix_timeout_u64 branch October 8, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants