make z_close take session by mutable reference #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'bug', 'enhancement', 'documentation', 'internal', 'new feature', 'breaking-change', 'dependencies'} |
DenisBiryukov91
force-pushed
the
session-close-by-reference
branch
from
611778f
to
13ff684
Compare
|
PR missing one of the required labels: {'new feature', 'breaking-change', 'documentation', 'dependencies', 'enhancement', 'bug', 'internal'} |
DenisBiryukov91
force-pushed
the
session-close-by-reference
branch
from
13ff684
to
973394f
Compare
DenisBiryukov91
added
enhancement
DenisBiryukov91
force-pushed
the
session-close-by-reference
branch
2 times, most recently
from
31dbbf8
to
869e1bc
Compare
DenisBiryukov91
force-pushed
the
session-close-by-reference
branch
from
869e1bc
to
0824bdc
Compare
jean-roland
approved these changes
Oct 4, 2024
sashacmc
reviewed
Oct 4, 2024
Co-authored-by: Alexander Bushnev <[email protected]>
sashacmc
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make z_close take session by mutable reference as it is done in rust;
session info methods can still be used on session after close (although with the exception of z_info_zid, they will return nothing);