-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Cyclone DDS Iceoryx shared memory PSMX plugin #213
Conversation
This should now be complete but I'm waiting for a new release of cyclors before marking it as ready for review. Tested on Linux and Windows. Note that the Iceoryx PSMX plugin doesn't compile on Windows so the shared memory feature is not supported on this platform. @JEnoch if you have time to test this on Mac that would be appreciated. When Use of the feature in forward discovery mode is currently limited to serialized PSMX samples only due to the lack of type information across the bridge. Samples will be serialized where the type contains indirections such as strings. |
I confirm it works as expected on MacOS. $ ./iox-roudi
$ ./target/debug/zenoh-bridge-dds -d 0 --dds-enable-shm
$ ./target/debug/zenoh-bridge-dds -d 1 --dds-enable-shm
$ CYCLONEDDS_URI='<CycloneDDS><Domain Id="0"><General><Interfaces><PubSubMessageExchange name="iox" library="psmx_iox" /></Interfaces></General></Domain></CycloneDDS>' ./HelloworldSubscriber
$ CYCLONEDDS_URI='<CycloneDDS><Domain Id="1"><General><Interfaces><PubSubMessageExchange name="iox" library="psmx_iox" /></Interfaces></General></Domain></CycloneDDS>' ./HelloworldPublisher |
PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal |
PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal |
PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal |
Rebased to main. @JEnoch can you review, please? |
PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal |
PR missing one of the required labels: breaking-change bug dependencies documentation enhancement new feature internal |
Tested on MacOS with Iceoryx 2.0.5, CycloneDDS 0.10.5 and HelloWorld example (IDL modified to remove @key). Commands:
|
This PR updates the DDS plugin/bridge to support the new Iceoryx PSMX plugin in Cyclone DDS and removes support for the previous Iceoryx shared memory implementation.
Closes #212