Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cyclors to a version which mangles C symbols to allow different versions of the library to be loaded in the same static binary. #376

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

gmartin82
Copy link
Contributor

Partly addresses #346.

Copy link

PR missing one of the required labels: {'bug', 'breaking-change', 'internal', 'new feature', 'enhancement', 'documentation', 'dependencies'}

@gmartin82 gmartin82 added the bug Something isn't working label Oct 22, 2024
@gmartin82
Copy link
Contributor Author

In absence of CI support I've manually tested cross building the DDS plugin (logs below). In all cases the symbols had been mangled as expected.

aarch64-unknown-linux-gnu.log
aarch64-unknown-linux-musl.log
arm-unknown-linux-gnueabi.log
arm-unknown-linux-gnueabihf.log
armv7-unknown-linux-gnueabihf.log
x86_64-unknown-linux-musl.log

@gmartin82 gmartin82 marked this pull request as ready for review October 29, 2024 11:18
@gabrik gabrik merged commit 3a4cc03 into eclipse-zenoh:main Oct 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants