Make FIFO (try)recv{,_deadline,_timeout} return ZResult<Option<T>>
#1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
force-pushed
the
hide-flume-fixup
branch
from
c79bf5d
to
8cab592
Compare
fuzzypixelz
added
enhancement
fuzzypixelz
force-pushed
the
hide-flume-fixup
branch
from
8cab592
to
c126db6
Compare
DenisBiryukov91
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #1504 removed the
flumeerror types; inzenohall errors areBox<dyn std::error::Error>(for what it's worth). For distinguishing "disconnected" and "empty/timeout" channel errors, anOptionis used, exactly likeRingChannelHandler.I believe we could've used proper error types, but it's too late for that now.