feat!: add background method to builders with callback #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyfo
added
breaking-change
milyin
requested changes
Oct 8, 2024
| /// } else { | ||
| /// println!("Publisher has NO MORE matching subscribers."); | ||
| /// } | ||
| /// }) |
There was a problem hiding this comment.
there is no background() call in the example
There was a problem hiding this comment.
Oups, indeed, it's fixed
| pub fn undeclare_on_drop(mut self, undeclare_on_drop: bool) -> Self { | ||
| self.undeclare_on_drop = undeclare_on_drop; | ||
| self | ||
| /// Background builder doesn't return a `MatchingListener` object anymore. |
There was a problem hiding this comment.
better to reformulate this, this is piece of documentation, not a comment to PR
There was a problem hiding this comment.
How do you want to reformulate?
There was a problem hiding this comment.
Something like this:
"Suppress returning MatchingListener object from builder. The listener callback stays alive for the lifetime of the session ". Doesn't matter too much though
| impl<'a, 'b> QueryableBuilder<'a, 'b, Callback<Query>> { | ||
| /// Register the queryable callback to be run in background until the session is closed. | ||
| /// | ||
| /// Background builder doesn't return a `Queryable` object anymore. |
There was a problem hiding this comment.
same. User doesn't care that we have different variant of builders, background, not background. Better to describe how this option affects behavior
wyfo
force-pushed
the
background_is_back
branch
from
bfe39fa
to
3adbf75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.