refactor: use HashSet instead of Vec for network links #1739
+46
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links are used a lot for `contains` operation.
|
PR missing one of the required labels: {'documentation', 'new feature', 'bug', 'internal', 'enhancement', 'breaking-change', 'dependencies'} |
Mallets
requested changes
Jan 29, 2025
| @@ -1,3 +1,4 @@ | |||
| use std::collections::HashSet; | |||
| @@ -1,3 +1,4 @@ | |||
| use std::collections::HashSet; | |||
| @@ -752,7 +753,7 @@ impl Network { | |||
| tracing::trace!("Update edge (link) {} {}", self.graph[self.idx].zid, zid); | |||
| self.update_edge(self.idx, idx); | |||
| } | |||
| self.graph[self.idx].links.push(zid); | |||
| self.graph[self.idx].links.insert(zid); | |||
There was a problem hiding this comment.
Here there is a semantic change where before the same ZenohId could be present multiple times in the Vec<ZenohIdProto> while now it can be present only once.
Maybe is it worth adding a debug log if insert(zid) returns Some? It would allow to detect if something else is going wrong. What do you think?
| @@ -1,3 +1,4 @@ | |||
| use std::collections::HashSet; | |||
| @@ -756,7 +757,7 @@ impl Network { | |||
| tracing::trace!("Update edge (link) {} {}", self.graph[self.idx].zid, zid); | |||
| self.update_edge(self.idx, idx); | |||
| } | |||
| self.graph[self.idx].links.push(zid); | |||
| self.graph[self.idx].links.insert(zid); | |||
There was a problem hiding this comment.
Same comment as above on adding a debug log message is insert(zid) returns Some?
|
No observed performance improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links are used a lot for
containsoperation.