Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment the version of org.eclipse.ecf.remoteservice.servlet.feature #119

Conversation

merks
Copy link
Contributor

@merks merks commented Jul 11, 2024

  • This is needed so that baseline replacement doesn't try to replace the newly built feature which includes jakarta.servlet-api version 6.1.0 with the previous version that includes jakarta.servlet-api version 6.0.0.

#116

- This is needed so that baseline replacement doesn't try to replace the
newly built feature which includes jakarta.servlet-api version 6.1.0
with the previous version that includes jakarta.servlet-api version
6.0.0.

eclipse#116
@eclipse-ecf-bot
Copy link

Can one of the admins verify this patch?

@merks
Copy link
Contributor Author

merks commented Jul 11, 2024

@scottslewis

I was able to reproduce the problem by enabling the baseline-checks profile during the local Tycho build. The change of this PR fixed the problem.

I appears the verification build does not enable this profile such that it might happen that one doesn't notice the problem until after you've merged some changes that appear otherwise fine.

@scottslewis scottslewis merged commit 5773b05 into eclipse:master Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants