Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwind the exception causes with Java11Http#performConnect #93

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 3, 2024

Currently there is a generic exception caught for all kind of errors but as the execution is actually performed async this means that any exception is already wrapped in an ExecutionException holding the real cause.

This unwinds the different causes that an happen (e.g. cancel, timeout, ...) and finally checks if this is an ExecutionException from the async operation-

Currently there is a generic exception caught for all kind of errors but
as the execution is actually performed async this means that any
exception is already wrapped in an ExecutionException holding the real
cause.

This unwinds the different causes that an happen (e.g. cancel, timeout,
...) and finally checks if this is an ExecutionException from the async
operation-
@laeubi
Copy link
Member Author

laeubi commented Dec 29, 2024

@scottslewis can this be merged?

@scottslewis scottslewis merged commit fa13d49 into eclipse:master Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants