-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX - Keycloak server execution failing at startup #3894
Conversation
…ontent with developer guide
Codecov Report
@@ Coverage Diff @@
## develop #3894 +/- ##
=============================================
- Coverage 20.54% 20.52% -0.02%
Complexity 6 6
=============================================
Files 1940 1944 +4
Lines 41547 41649 +102
Branches 3940 3946 +6
=============================================
+ Hits 8534 8549 +15
- Misses 32616 32703 +87
Partials 397 397
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, I want to suggest to switch to KEYCLOAK_SSL_ENABLE
instead of KEYCLOAK_DISABLE_SSL
which enables SSL when is false
and disable SSL true
. We can talk about this, if there is any doubt on this point
Second, it would be possible to have the Keycloak SSL enabled based on the --ssl
option available in the Docker Compose deployment? "One SSL option to rule them all" it is easier to use.
Please also remove KEYCLOAK_*
env defined in deployment/docker/compose/docker-compose.yml
for the kapua-console
component.
KC=/opt/keycloak/bin/kcadm.sh | ||
|
||
echo "Kapua Keycloak Configuration:" | ||
echo " Kapua Console URL: $KAPUA_CONSOLE_URL" | ||
echo " Keycloak Realm: $REALM_NAME" | ||
echo " Keycloak Admin User: $KEYCLOAK_USER" | ||
echo " Keycloak TLS disabled: $KEYCLOAK_DISABLE_SSL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use this reverse logic ENV to enable component.
It is far easier to understand KEYCLOAK_SSL_ENABLE
when is defined and used.
The default can be false
to indicate that a feature is disabled by default.
…ua-console-sso compose file
…tions on keycloak
The startup of the keycloak server inside the kapua/kapua-keycloak image was failing due to missing of some parameters in the startup script. Basically, the server was started in production mode but this mode requires additional configurations of some aspects, as stated here https://www.keycloak.org/server/configuration-production, that was missing.
With this PR, I inserted the missing configuration parameters. In this way, with the kapua/kapua-keycloak image (so, with the --sso option on the deploy) we propose a demo image to test the sso feature. Finally, I updated the documentation, particularly in the part were it is explained how to run a stand-alone keycloak image for the case of a (real) production mode deployment.
Specifically, I worked on these aspects