Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - CI configuration improvements #3912

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

Agnul97
Copy link
Contributor

@Agnul97 Agnul97 commented Nov 30, 2023

Basically, this PR is a "partial" port of this previous PR merged in develop #3785 that involved a lot of optimizations in the ci configuration.

Here, I changed these aspects of the configuration:

  1. The caching mechanism was redundant between the actions/setup-java@v3 and actions/cache@v3 gitActions. I removed the caching in the first one to only have it in the second one.
  2. The key used for the caching was wrong, for the same reason explained in point 4 of the pr FIX - Ci improvement - maven artifact caching and various tweaks #3785. I corrected it in the same way introducing the same "pr-commit-unique" key.
  3. removed the restore-key parameter that was afflitected by the same problem of the point 3.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #3912 (9f0f7e8) into release-1.7.x (b188082) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-1.7.x    #3912      +/-   ##
===================================================
- Coverage            49.68%   49.63%   -0.06%     
  Complexity             882      882              
===================================================
  Files                 1604     1604              
  Lines                36680    36680              
  Branches              3719     3719              
===================================================
- Hits                 18226    18206      -20     
- Misses               17261    17283      +22     
+ Partials              1193     1191       -2     

see 7 files with indirect coverage changes

Copy link
Contributor

@riccardomodanese riccardomodanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks!

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! build labels Dec 1, 2023
@Coduz Coduz merged commit 81b0a39 into eclipse:release-1.7.x Dec 1, 2023
25 of 26 checks passed
@Coduz Coduz changed the title FIX - CI configiguration imrovements FIX - CI configuration improvements Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! build
Projects
Development

Successfully merging this pull request may close these issues.

3 participants