Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Job] Support for JSON-formatted in JobStepProperties.value for complex properties #4161

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Dec 19, 2024

This PR introduces the capability of using JSON formatted object in JobStepProperties, which previously allowed only XML

Related Issue
None

Description of the solution adopted
Added support by lazily try both formats when reading the property.

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Dec 19, 2024
@Coduz Coduz requested a review from stefanomorson December 19, 2024 15:55
@Coduz Coduz force-pushed the feat-jobStepPropertiesAsJsonValue branch from 0f3bcfa to 7bf7db6 Compare December 19, 2024 16:07
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 16.76%. Comparing base (18b3991) to head (7bf7db6).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
.../service/job/step/internal/JobStepServiceImpl.java 0.00% 13 Missing ⚠️
...ob/engine/commons/wrappers/StepContextWrapper.java 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4161      +/-   ##
=============================================
- Coverage      16.76%   16.76%   -0.01%     
  Complexity        22       22              
=============================================
  Files           2039     2039              
  Lines          52850    52862      +12     
  Branches        4441     4441              
=============================================
  Hits            8860     8860              
- Misses         43587    43599      +12     
  Partials         403      403              
Files with missing lines Coverage Δ
...ition/DeviceConfigurationPutJobStepDefinition.java 0.00% <ø> (ø)
...ob/engine/commons/wrappers/StepContextWrapper.java 0.00% <0.00%> (ø)
.../service/job/step/internal/JobStepServiceImpl.java 0.00% <0.00%> (ø)

@Coduz Coduz merged commit 8803e6c into eclipse:develop Dec 20, 2024
33 of 36 checks passed
@Coduz Coduz deleted the feat-jobStepPropertiesAsJsonValue branch December 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
Development

Successfully merging this pull request may close these issues.

1 participant