Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-build protoc from source #585

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Pre-build protoc from source #585

merged 1 commit into from
Jun 30, 2023

Conversation

rafaeling
Copy link
Contributor

@rafaeling rafaeling commented Jun 27, 2023 •
edited
Loading

It closes this issue: #557

erikbosch
erikbosch approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified in the build logs that it builds v1.1, but I am no Rust expert so best if @argerus also reviews

2023-06-27T09:50:38.3844092Z #30 56.14 Compiling protobuf-src v1.1.0+21.5

argerus
argerus requested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@argerus argerus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mean we don't have any dependency on protoc.

We should probably remove the "install protoc" steps from the github actions, as they take time.

@rafaeling rafaeling force-pushed the fix-protoc_compiler_installation_during_build branch from 406a629 to ebd29cc Compare June 29, 2023 11:58
@erikbosch erikbosch merged commit 890703c into eclipse:master Jun 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argerus argerus argerus approved these changes

@erikbosch erikbosch erikbosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaeling @argerus @erikbosch