Upgrade Boost for KUKSA.val Server #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background reason:
Newer gcc versions give more warnings, and we treat warnings as errors.
We get a warning on boost that has been fixed in recent Boost versions
/home/erik/kuksa.val/kuksa-val-server/build/_deps/boost-build/include/boost/thread/pthread/thread_data.hpp:61:19: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare]
61 | if (size<PTHREAD_STACK_MIN) size=PTHREAD_STACK_MIN;
| ^
compilation terminated due to -Wfatal-errors.
cc1plus: all warnings being treated as errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background reason:
Newer gcc versions give more warnings, and we treat warnings as errors. We build our Docker container using alpine:3.11, but if you try to build locally there is big risk that you have a newer gcc version and runs into problems. The problems can be fixed by changing include and upgrading Boost version, as newer Boost has added a cast to the line below:
Tests performed: