-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update status and author for kuksa-client #602
Conversation
@@ -27,7 +27,6 @@ install_requires = | |||
websockets >= 10.1 | |||
cmd2 >= 1.4, <2.0 | |||
pygments >= 2.5 | |||
importlib_metadata >= 3.6 ; python_version < "3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was useless as it only should be installed for Python versions below 3.8, but we require at least 3.8 so it will never trigger
@@ -11,7 +11,7 @@ project_urls= | |||
Bug Tracker=https://github.com/eclipse/kuksa.val/issues | |||
classifiers = | |||
Intended Audience :: Developers | |||
Development Status :: 3 - Alpha | |||
Development Status :: 5 - Production/Stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be discussed, but I would say kuksa-client has passed alpha stage
https://pypi.org/classifiers/
https://martin-thoma.com/software-development-stages/
I am trying to make a status proposal at https://github.com/eclipse/kuksa.val/wiki/KUKSA.val-Component-Maturity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would agree with production/stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. We might have a long argument about whether it is 4 or 5, but anyway, this is one of our few main/core components and it has been a long time around and is reasonably stable.
kuksa-client/setup.cfg
Outdated
description = kuksa.val python clients and SDK | ||
author = Eclipse KUKSA Project | ||
author_email = [email protected] | ||
description = KUKSA.val Python Client and SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just calling it
KUKSA Python Client and SDK
(I remember we had some side discussion, dropping the VAL. IF you agree or are indifferent, pls change, if somebody vetos it, I am fine with keeping .val as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem dropping .val
whenever used. Should I possibly update https://github.com/eclipse/kuksa.val/wiki/KUKSA.val-Naming-Guidelines to reflect that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if we drop it we should change it there too. https://github.com/eclipse/kuksa.val/wiki/KUKSA.val-Naming-Guidelines but htis link does not work for me :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if we drop it we should change it there too. https://github.com/eclipse/kuksa.val/wiki/KUKSA.val-Naming-Guidelines but htis link does not work for me :/
That is because I changed the name to https://github.com/eclipse/kuksa.val/wiki/KUKSA-Naming-Guidelines
Fixes #599
An example on the result can be seen in pypi, see https://test.pypi.org/project/kuksa-client/0.4.0a6/