Remove optional
from kuksa.val.v1 proto
#690
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation that remains wire-protocol compatible.
Turns out it's actually source compatible when using python, which is good.
Example of the "clunkyness" of using it in Rust (and probably C++).
Not great, not terrible.
And technically, those who want use
optional
can just use an alternative.proto
, as it's all compatible on the wire anyway.