Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version number in spec and references to spec #607

Merged
merged 1 commit into from
May 15, 2024
Merged

update version number in spec and references to spec #607

merged 1 commit into from
May 15, 2024

Conversation

benjamin-confino
Copy link
Contributor

This resolves #606

@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

MikeEdgar
MikeEdgar requested changes May 2, 2024
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
api/src/main/java/org/eclipse/microprofile/openapi/annotations/Components.java Outdated Show resolved Hide resolved
@Azquelt
Copy link
Member

Azquelt commented May 2, 2024 •
edited
Loading

Please refer to https://spec.openapis.org/oas/v3.1.0.html for the correct name of anything and link within that document where our spec needs to link to the OpenAPI spec.

This issue is not a simple find and replace of 3.0 with 3.1.

@benjamin-confino benjamin-confino marked this pull request as draft May 3, 2024 09:18
@benjamin-confino benjamin-confino force-pushed the 606-update-version-spec branch 5 times, most recently from 38d1cf5 to 7f026ea Compare May 3, 2024 12:47
@benjamin-confino benjamin-confino marked this pull request as ready for review May 3, 2024 12:47
@benjamin-confino
Copy link
Contributor Author

If everything looks good I'll squash this down.

@Azquelt
Copy link
Member

Azquelt commented May 3, 2024

The last commit puts double-hashes in all the URLs.

Azquelt
Azquelt reviewed May 3, 2024
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
@Azquelt Azquelt mentioned this pull request May 3, 2024
Open
@Azquelt Azquelt mentioned this pull request May 13, 2024
Merged
Azquelt
Azquelt requested changes May 13, 2024
View reviewed changes
Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the links now look good, but in many cases the link text was wrong or inconsistent (either changed accidentally in this PR, or was incorrect before).

...rc/main/java/org/eclipse/microprofile/openapi/annotations/security/SecurityRequirements.java Outdated Show resolved Hide resolved
...main/java/org/eclipse/microprofile/openapi/annotations/security/SecurityRequirementsSet.java Outdated Show resolved Hide resolved
...ain/java/org/eclipse/microprofile/openapi/annotations/security/SecurityRequirementsSets.java Outdated Show resolved Hide resolved
api/src/main/java/org/eclipse/microprofile/openapi/annotations/info/Contact.java Outdated Show resolved Hide resolved
api/src/main/java/org/eclipse/microprofile/openapi/annotations/info/Info.java Outdated Show resolved Hide resolved
api/src/main/java/org/eclipse/microprofile/openapi/models/servers/Server.java Outdated Show resolved Hide resolved
api/src/main/java/org/eclipse/microprofile/openapi/models/servers/ServerVariable.java Outdated Show resolved Hide resolved
spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/microprofile-openapi-spec.asciidoc Outdated Show resolved Hide resolved
@Azquelt
Copy link
Member

Azquelt commented May 13, 2024

I have belatedly noticed that many of my suggested changes will need re-wrapped by the autoformatter.

Azquelt
Azquelt approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been through and checked all of the links, this now looks good to me.

@MikeEdgar
Copy link
Member

@eclipse-microprofile-bot test this please

@benjamin-confino
Copy link
Contributor Author

Excellent news. Now it is time to squash this all down.

@benjamin-confino benjamin-confino force-pushed the 606-update-version-spec branch from 05a86d6 to a0068d1 Compare May 14, 2024 20:05
@MikeEdgar MikeEdgar merged commit 5db8757 into eclipse:main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

@Azquelt Azquelt Azquelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OAS 3.1.0] Update spec document references
4 participants
@benjamin-confino @eclipse-microprofile-bot @Azquelt @MikeEdgar