Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration for OpenShift deployment and Eclipse Che development #1011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svor
Copy link

@svor svor commented Oct 8, 2024

This PR introduces a .devfile.yaml that sets up a complete development environment in Eclipse Che for developing, testing, and running OpenVSX.

Watch the screencast to see how it works:
Run_in_Che.webm

The PR also includes a deployment configuration for OpenShift, enabling the deployment and operation of a custom OpenVSX registry on OpenShift. Additionally, it provides the capability to patch Eclipse Che, allowing it to seamlessly integrate and use this custom registry.

Watch the screencast to see how it works:
Deploy_on_OpenShift.webm

A new badge has been added to the main README.md, providing a direct link to open the Eclipse Che developer environment for working with OpenVSX:
screenshot-meet_google_com-2024_10_08-17_13_35

Related issue: eclipse-che/che#23148

.devfile.yaml Outdated Show resolved Hide resolved
.devfile.yaml Outdated Show resolved Hide resolved
@amvanbaren
Copy link
Contributor

@svor Who's going to maintain the openshift directory?

@ibuziuk
Copy link
Member

ibuziuk commented Oct 16, 2024

@amvanbaren Red Hat is going to support the openshift directory. We can contribute the CODEOWNERS file if needed with the specific list of developers

@amvanbaren
Copy link
Contributor

@ibuziuk I think it might be better to move the openshift directory to a separate repo. I'm happy to add a link to it in the wiki: https://github.com/eclipse/openvsx/wiki/Deploying-Open-VSX

@ibuziuk
Copy link
Member

ibuziuk commented Oct 30, 2024

@amvanbaren could you clarify why not to have it in the upstream repo? There are already other product config files / setup for cloud providers available in repository and README.

@amvanbaren
Copy link
Contributor

@ibuziuk Yes, those configurations are directly related to running the Open VSX registry (Azure blob storage, Google cloud storage, Github authentication). While running Open VSX on OpenShift is one of numerous ways how the infrastructure can be set up.

@ibuziuk
Copy link
Member

ibuziuk commented Oct 31, 2024

@amvanbaren well, there are also product-specific configuration files in place for development - https://github.com/eclipse/openvsx?tab=readme-ov-file#development

@amvanbaren
Copy link
Contributor

@ibuziuk The proposed changes in README.md and development.md are ok, but I think it might be better to move the openshift directory to the Eclipse Che repo or a new repo.

@deboer-tim
Copy link

This does seem to contradict Eclipse vendor-neutral governance though? Why one product included and not another?
@kineticsquid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants