Hoist GateFuser to quantum/gate/utils and simplify API #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, multiple plugins can use GateFuser without needing to link with each other or use the service registry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, multiple plugins can use GateFuser without needing to link with each other or use the service registry.
My attempt at fixing #518. It feels like GateFuser could fit well in
quantum/gate/utils, since you need to change it if you add a new XACC IR instruction, so I moved it up there.Testing
Did a clean build and ran
ctest, which passed. I also did a clean build of qcor and ran a qcor benchmark for the ion trap backend, and it worked.I couldn't reproduce the original behavior, but I hope fixes the root problem of the iontrap plugin linking with another plugin (which I somehow didn't realize was bad)