Loki: Small fixes and clean-up; EC_PMON removal #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlange05
force-pushed
the
naml-spring-clean
branch
from
44a7bfe to
eb422ca
Compare
reuterbal
approved these changes
Jan 18, 2025
mlange05
force-pushed
the
naml-spring-clean
branch
from
eb422ca to
6f52efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent upstream changes in Loki the test case was no longer clean. This PR brings a few small changes that should remedy that, and removes the use of EC_PMON, an outdated power measurement utility on the old Cray system.
In more detail: