eqctier3-6cea0c38-0a26-4b6e-8673-d8349bf10b9d #102
Conversation
|
|
@malmans2 I have added subfolders for CMIP6 and CORDEX to avoid the need to use these in the titles (which is not very user friendly in the sidebar or section TOC). Please check if there are any implications for permalinks, or something I haven't foreseen, before the squash and merge. Note that we will also want to activate the subsections for ECVs, but that will be easier as the .ipynbs are already in subfolders (but we do want to split Land_Hydrology&Cryosphere_ECVs into two sections). |
|
We should make changes like this in separate PRs, merge them into the main branch, and then merge the updated main into the other PRs. This is important because the changes affect the repo structure and impact all notebooks (in this case, all CMIP6 and CORDEX notebooks). All climate projection permalinks and previews will be affected, as the subdirectory is part of the URL. Therefore, these notebooks should not be approved until the new permalink is shared in the CIM. I'll open a separate PR and ping you there for review. |
|
Ah okay, I guess I misunderstood the 'perma' in permalink then. So after this is merged to main, a link like this will break? 'https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/61ed6d347dc7aa7646d5c98764979a94a0aa8c01/Climate_Projections/climate_projections-cmip6_climate-and-weather-extremes_q02.ipynb' On the implications for CORDEX, that does make sense. I was planning to merge the changes from main (adding CMIP6, and the subfolders) into the CORDEX branch when I work on that. For now I will only push the other changes to the CORDEX nbs (fixing icons, headings etc) and not change the folder structure. |
|
That permalink won't break and will remain functional. However, I'm worried about the Jupyter Book URL. If I understand correctly, the CIM infers the Jupyter Book URL from the permalink, and that's the URL displayed in the web portal. If we change the filename or location of the file, the Jupyter Book URL will also change. Therefore, if the notebook is approved before this change is communicated in the CIM, the web portal will end up with a broken URL. |
|
The inference is not in place yet, so we manually add the book link in the CIM at the final approval step - so for now it will not be an issue! |
|
OK, so no problem if the change is made before the final approval step. |
|
Waiting for the outcome of the splitting PR before the merge |
Closes #47
Closes #48
Closes #91
Closes #92
Closes #95
Closes #96