Chore fill anemoi models #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows Distributed Data Parallel Co-authored-by: Jesper Dramsch <[email protected]> Co-authored-by: Simon Lang <[email protected]> Co-authored-by: Matthew Chantry <[email protected]> Co-authored-by: Mihai Alexe <[email protected]>
Co-authored-by: Jesper Dramsch <[email protected]>
Encompasses encoder, processor and decoder structure. Co-authored-by: Jesper Dramsch <[email protected]> Co-authored-by: Matthew Chantry <[email protected]> Co-authored-by: Simon Lang <[email protected]> Co-authored-by: mihai.alexe <[email protected]>
Dynamic data handling and indexing Co-authored-by: Florian Pinault <[email protected]> Co-authored-by: Baudouin Raoult <[email protected]> Co-authored-by: Matthew Chantry <[email protected]> Co-authored-by: mihai.alexe <[email protected]> Co-authored-by: Simon Lang <[email protected]>
Pytorch model interface Co-authored-by: Jesper Dramsch <[email protected]> Co-authored-by: Simon Lang <[email protected]> Co-authored-by: Matthew Chantry <[email protected]> Co-authored-by: Mihai Alexe <[email protected]>
Co-authored-by: Jesper Dramsch <[email protected]> Co-authored-by: Matthew Chantry <[email protected]> Co-authored-by: Mihai Alexe <[email protected] Co-authored-by: Florian Pinault <[email protected]> Co-authored-by: Baudouin Raoult <[email protected]>
test config missing Co-authored-by: Jesper Dramsch <[email protected]>
Co-authored-by: Simon Lang <[email protected]> Co-authored-by: Helen Theissen <[email protected]>
--------- Co-authored-by: Steffen Tietsche <[email protected]> Co-authored-by: Helen Theissen <[email protected]> Co-authored-by: Sara Hahner <[email protected]> Co-authored-by: Mariana Clare <[email protected]> Reviewed-by: Mariana Clare <[email protected]>
|
Distributed folder has no init. |
mchantry
reviewed
May 29, 2024
Co-authored-by: Matthew Chantry <[email protected]>
|
Some tests fail with flash-attention, I'm not sure that should be a blocker, but just an issue to fix. |
mchantry
reviewed
May 29, 2024
| t, "(batch grid) (heads vars) -> batch heads grid vars", batch=batch_size, heads=self.num_heads | ||
| ), | ||
| (query, key, value), | ||
| query, key, value = ( |
There was a problem hiding this comment.
Readability mostly.
mchantry
reviewed
May 29, 2024
| query, key, value = map( | ||
| lambda t: einops.rearrange(t, "batch heads grid vars -> batch grid heads vars"), | ||
| (query, key, value), | ||
| query, key, value = ( |
There was a problem hiding this comment.
As above, what's the pro of the refactor?
There was a problem hiding this comment.
mostly readability
mchantry
reviewed
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of anemoi-models components including the following modules: