[Feature] 28 Make models switchable through the config #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchantry
added
ATS approved
…dels-switchable-through-the-config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #45 +/- ##
========================================
Coverage 99.84% 99.84%
========================================
Files 23 23
Lines 1277 1277
========================================
Hits 1275 1275
Misses 2 2 ☔ View full report in Codecov by Sentry. |
JesperDramsch
deleted the
feature/28-make-models-switchable-through-the-config
branch
theissenhelen
pushed a commit
that referenced
this pull request
Sep 27, 2024
* feat: make model instantiateable * docs: instantiation explained in changelog * refactor: rename model config object * fix: rename config to model_config * fix: mark non-recursive * docs: changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables instantiation of the model through hydra
Closes #28