Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLflow token authentication #2

Merged
merged 41 commits into from
Jul 18, 2024
Merged

MLflow token authentication #2

merged 41 commits into from
Jul 18, 2024

Commits on Jun 25, 2024

  1. Update dependencies

    @gmertes
    gmertes committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3531281 View commit details
    Browse the repository at this point in the history

  2. Add mlflow subpackage

    @gmertes
    gmertes committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1c95835 View commit details
    Browse the repository at this point in the history

  3. Add auth module

    @gmertes
    gmertes committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    624fabb View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Use unix time

    @gmertes
    gmertes committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fbe8d0a View commit details
    Browse the repository at this point in the history

  2. Store new refresh token in memory

    @gmertes
    gmertes committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a05a374 View commit details
    Browse the repository at this point in the history

  3. Use anemoi.utils.config

    @gmertes
    gmertes committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7dec83c View commit details
    Browse the repository at this point in the history

  4. Add authenticate fn

    @gmertes
    gmertes committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    683069b View commit details
    Browse the repository at this point in the history

  5. Load config on init

    @gmertes
    gmertes committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7e5bb01 View commit details
    Browse the repository at this point in the history

  6. Refactor login logic

    @gmertes
    gmertes committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    70bf8c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Add force credentials arg

    @gmertes
    gmertes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    224897d View commit details
    Browse the repository at this point in the history

  2. Check refresh token expiry on auth

    @gmertes
    gmertes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    460d598 View commit details
    Browse the repository at this point in the history

  3. Handle error status

    @gmertes
    gmertes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    de93951 View commit details
    Browse the repository at this point in the history

  4. Retry login with credentials if token fails

    @gmertes
    gmertes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    aecf26a View commit details
    Browse the repository at this point in the history

  5. Add mlflow command

    @gmertes
    gmertes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ff3206b View commit details
    Browse the repository at this point in the history

  6. Assert url

    @gmertes
    gmertes committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2140a56 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Header

    @gmertes
    gmertes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    868f269 View commit details
    Browse the repository at this point in the history

  2. Add docstrings

    @gmertes
    gmertes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c5acb4f View commit details
    Browse the repository at this point in the history

  3. Fix logger import

    @gmertes
    gmertes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    c4d9a4e View commit details
    Browse the repository at this point in the history

  4. Make refresh token a property, update expiry in setter

    @gmertes
    gmertes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d39541f View commit details
    Browse the repository at this point in the history

  5. Refactor token request, update refresh token on auth

    @gmertes
    gmertes committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    f7fb94a View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Update mlflow logger to latest aifs-mono version

    @gmertes
    gmertes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f4b781c View commit details
    Browse the repository at this point in the history

  2. Use code logger

    @gmertes
    gmertes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6e8bfcc View commit details
    Browse the repository at this point in the history

  3. Return a global auth instance with get_auth

    @gmertes
    gmertes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d7b2abc View commit details
    Browse the repository at this point in the history

  4. Add enabled decorator

    @gmertes
    gmertes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4a7509c View commit details
    Browse the repository at this point in the history

  5. Log refresh token expiry date

    @gmertes
    gmertes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    131b138 View commit details
    Browse the repository at this point in the history

  6. Simplify expiry calculation

    @gmertes
    gmertes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c4d8b2e View commit details
    Browse the repository at this point in the history

  7. Remove assert url

    @gmertes
    gmertes committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6edf62d View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Remove global auth facility

    @gmertes
    gmertes committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    fb2c2e8 View commit details
    Browse the repository at this point in the history

  2. Integrate TokenAuth into AIFSMLflowLogger

    @gmertes
    gmertes committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    b3a1ea8 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Only initialise on rank 0

    @gmertes
    gmertes committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    04f90d5 View commit details
    Browse the repository at this point in the history

  2. Log time it takes to refresh token

    @gmertes
    gmertes committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    47d7e69 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @gmertes
    gmertes committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9e036a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Add authentication config entry

    @gmertes
    gmertes committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b0beb3b View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Comment

    @gmertes
    gmertes committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0fb6067 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Add health check

    @gmertes
    gmertes committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4ff1339 View commit details
    Browse the repository at this point in the history

  2. Make refresh token expiry a constant

    @gmertes
    gmertes committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b3ae738 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Make --url required, in absence of a config

    @gmertes
    gmertes committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    290e48f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Rename AIFSMLflowLogger -> AnemoiMLflowLogger

    @gmertes
    gmertes committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    edcd1e1 View commit details
    Browse the repository at this point in the history

  2. API update

    @gmertes
    gmertes committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    4756457 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. add ability to continue run in mlflow logs and not create child run 

    (cherry picked from commit ecmwf-lab/aifs-mono@b856ddd)

* add ability to continue run in mlflow logs and not create child run

add model init logic for weights only and all

bugfix: commented out synchronous arg in MLFLOW logger

fixed overwriting function with hidden property in AIFSMLflowLogger

* Update logging.py

Simplying the if block for setting log_hyperparams

* removed synchronous arg from config, refined code

* Update logged message

* removed synchronous param from AIFSMLflowLogger

* Added plot async param back

* change default setting for on_resume_create_child to False to maintain default behaviour from before this PR

---------

Co-authored-by: Rilwan (Akanni) Adewoyin <[email protected]>
    @gmertes @Rilwan-Adewoyin
    gmertes and Rilwan-Adewoyin committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    60a2928 View commit details
    Browse the repository at this point in the history

  2. Add mlflow sync command placeholder, update logging

    @gmertes
    gmertes committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    808bd3d View commit details
    Browse the repository at this point in the history