Enable HTTP-based authentication and authorisation ECFLOW-1960 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosbento
force-pushed
the
feature/authentication_and_authorization
branch
2 times, most recently
from
9e6094f to
a79c5fc
Compare
marcosbento
force-pushed
the
feature/support_http_comms
branch
from
a58251f to
33743ed
Compare
marcosbento
force-pushed
the
feature/authentication_and_authorization
branch
from
a79c5fc to
5e5ff72
Compare
marcosbento
force-pushed
the
feature/support_http_comms
branch
from
33743ed to
ad68056
Compare
marcosbento
force-pushed
the
feature/authentication_and_authorization
branch
from
5e5ff72 to
279d84d
Compare
- Separate Authentication (check for correct username and password), from Authorization (check if use permissions allow to execute command) Re ECFLOW-1960
marcosbento
force-pushed
the
feature/support_http_comms
branch
from
ad68056 to
cdacefe
Compare
marcosbento
force-pushed
the
feature/authentication_and_authorization
branch
from
279d84d to
b3ffac2
Compare
- Add scaffolding framework to perform Authorisation check Re ECFLOW-1960
- Update client to include token in request - Update server to consider Secured User (i.e. user authenticated by reverse-proxy, thus no need authentication by ecflow_server) Note: this could eventually replace ECF_PASSWD file, on the client-side Re ECFLOW-1960
marcosbento
force-pushed
the
feature/authentication_and_authorization
branch
from
b3ffac2 to
dd61e16
Compare
This algorithm allows visiting the nodes on a given path and to collect the applicable per node permission used for Authorisation Re ECFLOW-1960
Re ECFLOW-1960
Re ECFLOW-1960
Re ECFLOW-1960
marcosbento
force-pushed
the
feature/authentication_and_authorization
branch
3 times, most recently
from
5717867 to
86bedde
Compare
Re ECFLOW-1960
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/support_http_comms #158 +/- ##
==============================================================
+ Coverage 48.97% 49.29% +0.32%
==============================================================
Files 1192 1210 +18
Lines 98725 99198 +473
Branches 14807 14814 +7
==============================================================
+ Hits 48346 48896 +550
+ Misses 50379 50302 -77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcosbento
force-pushed
the
feature/authentication_and_authorization
branch
from
86bedde to
bd41e24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.