Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable status/attributes on /tree endpoint ECFLOW-1939 #84

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

Attention: 347 lines in your changes are missing coverage. Please review.

Comparison is base (dd7e55c) 79.96% compared to head (8d7cf22) 83.16%.

Files Patch % Lines
Http/src/ecflow/http/ApiV1.cpp 67.70% 124 Missing ⚠️
Http/src/ecflow/http/ApiV1Impl.cpp 57.31% 105 Missing ⚠️
Http/src/ecflow/http/TreeGeneration.hpp 68.37% 37 Missing ⚠️
Http/src/ecflow/http/TypeToJson.cpp 64.78% 25 Missing ⚠️
Http/src/ecflow/http/Client.cpp 59.52% 17 Missing ⚠️
Http/src/ecflow/http/Base64.hpp 0.00% 9 Missing ⚠️
ANode/src/ecflow/node/DefsTreeVisitor.hpp 80.95% 8 Missing ⚠️
Http/src/ecflow/http/JSON.cpp 38.46% 8 Missing ⚠️
Http/src/ecflow/http/DefsStorage.cpp 89.79% 5 Missing ⚠️
Http/src/ecflow/http/HttpServer.cpp 76.47% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #84      +/-   ##
===========================================
+ Coverage    79.96%   83.16%   +3.20%     
===========================================
  Files          630      600      -30     
  Lines        58345    53318    -5027     
===========================================
- Hits         46655    44344    -2311     
+ Misses       11690     8974    -2716     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento force-pushed the feature/http_improvements branch 4 times, most recently from 40e1f85 to 8e9ce09 Compare February 6, 2024 09:22
- Remove TokenStorage from build when OpenSSL is not available
- #include <httplib>
- Reduce using directives

Re ECFLOW-1939
- Separate Defs storage/cacheing from API implementation
- Separate Client(Invoker) creation/auth from API implementation
- Wrap #include <httplib.h>, to avoid repeated/inconsistent inclusion

Re ECFLOW-1939
@marcosbento marcosbento force-pushed the feature/http_improvements branch from 8e9ce09 to 8d7cf22 Compare February 8, 2024 10:27
- ecflow_http documentation was reorganized to place Endpoint specification close to request/response payload description
- overall review of ecflow_http documentation content

Re ECFLOW-1939
@marcosbento marcosbento changed the title ecflow REST API improvements ECFLOW-1939 Enable status/attributes on /tree endpoint ECFLOW-1939 Feb 9, 2024
@marcosbento marcosbento marked this pull request as ready for review February 9, 2024 12:30
@marcosbento marcosbento merged commit d778957 into develop Feb 9, 2024
54 checks passed
@marcosbento marcosbento deleted the feature/http_improvements branch February 9, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants