Update linking to correct CMake target #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ecflow is built as a `module` (i.e. a shared library, dynamically loaded by the Python interpreter), the linkage in macOs requires passing flags `-undefined` and `-dynamic_lookup`. This is handled directly by CMake which, since CMake 3.15, defines a specific target `Python3::Module` to be used when building Python modules. Re ECFLOW-1950
marcosbento
force-pushed
the
bugfix/correct_python_linkage
branch
from
6007b55 to
1d9e56b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #98 +/- ##
========================================
Coverage 84.54% 84.54%
========================================
Files 606 606
Lines 54037 54037
========================================
Hits 45686 45686
Misses 8351 8351 ☔ View full report in Codecov by Sentry. |
marcosbento
added a commit
that referenced
this pull request
Mar 27, 2024
Since ecflow is built as a `module` (i.e. a shared library, dynamically loaded by the Python interpreter), the linkage in macOs requires passing flags `-undefined` and `-dynamic_lookup`. This is handled directly by CMake which, since CMake 3.15, defines a specific target `Python3::Module` to be used when building Python modules. Re ECFLOW-1950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ecflow is built as a
module(i.e. a shared library, dynamically loaded by the Python interpreter), the linkage in macOs requires passing flags-undefinedand-dynamic_lookup. This is handled directly by CMake which, since CMake 3.15, defines a specific targetPython3::Moduleto be used when building Python modules.Re ECFLOW-1950