Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/geo #116

Merged
merged 763 commits into from
Jul 3, 2024
Merged

Feature/geo #116

merged 763 commits into from
Jul 3, 2024

Conversation

pmaciel
Copy link
Member

@pmaciel pmaciel commented Apr 6, 2024

This PR provides minimal functionality for a grid library, under eckit::geo and resulting in libeckit_geo.dylib. It is meant as a (much) larger superset of the eckit::geometry library which it intends to replace, as well as a very large rewrite.

It has basic support for the following:

  • regular ll, regular gg, reduced gg, ORCA, HEALPix grids (ring & nested); They can
    • iterate (inside eg. a for loop)
    • generate a list of points (a pair of lat/lon vectors, or a single list of points)
    • generate a spec ("gridspec"), which can be reused to recreate the same grid
    • be instantiated from a spec ("gridspec")
  • regular ll, regular gg, reduced gg grids can crop
  • the framework for Projections, Figure (shape and size), is in place
  • all new class hierarchies are fully adequate for Python interfaces (if need be), that is, the classes are components

Everything is done "as late as possible", and the expensive calculations are cached. There is sufficient support for ORCA grids cached to/from disk to support the existing stack.

What's not there:

  • ordering (GRIB scanningMode) handling (incl. HEALPix ordering: nested but that is simple to add now)
  • projections (incl. rotations), there is heavy testing done already (so it is simple to add now, one-by-one)

This is meant as a starting point. If one aims for full complete integration with eccodes, I would say we are 75% of the way there -- but the last % take longer.

This considers eccodes + atlas + mir + multio (the ORCA and HEALPix parts) + earthkit-regrid. There is also a parallel effort that can trigger most of the above functionality from eccodes, which has been considered for this design so it is suitable, with an equivalent grib_get_data (and an additional grib_get_data_diff) already supporting integration into eccodes (the first project with eckit::geo upstream of eccodes).

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

10 similar comments
Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756267235.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9756532112.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

12 similar comments
Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768503536.

Copy link

github-actions bot commented Jul 2, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9768807634.

@pmaciel pmaciel merged commit fd30bdf into develop Jul 3, 2024
216 of 228 checks passed
@pmaciel pmaciel deleted the feature/geo branch July 3, 2024 15:54
@iainrussell
Copy link
Member

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants