ECKIT-619 Enable PUT method on EasyCURL #81
Conversation
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #81 +/- ##
===========================================
- Coverage 62.85% 62.17% -0.68%
===========================================
Files 796 784 -12
Lines 45287 44467 -820
===========================================
- Hits 28463 27647 -816
+ Misses 16824 16820 -4
☔ View full report in Codecov by Sentry. |
Currently there are no tests for CURL, but I'll definitely have a look at your suggestion regarding using our Nexus servers as target end points. |
A specific test file was created containing the existing EasyCURL test. The existing EasyCURL test itself was updated to correct the URL used to access the test data at ECMWF's Nexus Repository.
| curl.headers(headers); | ||
|
|
||
| auto response = curl.GET("https://get.ecmwf.int/service/rest/v1/assets?repository=test-data"); | ||
| EXPECT(response.code() == 200); |
There was a problem hiding this comment.
Can we have some GET tests that fail (i.e. not just code == 200)
tests/io/test_easycurl.cc
Outdated
| curl.headers(headers); | ||
|
|
||
| auto response = curl.PUT("https://get.ecmwf.int/service/rest/v1/security/anonymous", ""); | ||
| EXPECT(response.code() == 403); |
There was a problem hiding this comment.
Any chance of a successful PUT request? Nothing here demonstrates that the data is being passed through properly.
Ideally a PUT request that can re-retrieve the data, and compare.
There was a problem hiding this comment.
I'm consulting with @iainrussell to see if there is any way to make a PUT request on our Nexus, without needing authentication (i.e. with public access).
If you have any idea, let us know.
The tests exercise EasyCURL calls for GET, POST, PUT and DELETE. Existing and new tests are supported by a Python-based Mock REST API that stores key+value pairs. A Python environment with Flask is necessary to run the Mock REST API.
|
Hi @simondsmart , @tlmquintino I've added a more elaborate test (covering GET, POST, PUT and DELETE methods) , based on a mock REST API implemented in Python+Flask. Can you please have another look? |
|
Hi @simondsmart , @tlmquintino Are you happy to merge this PR now? |
This pull request provides a
readCallbackto enable uploading the HTTP PUT request body, and updates theEasyCURL::PUTto effectively process the PUT method request.