[WIP] Initial draft of python interface with pybind #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This change gets the location of the eccodes binaries from an arbitray selected eccodes binary to ensure the binaries can be found if they are installed into a non default location.
'fdb-purge' is now using the '--config' flag as advertised in '--help'
'fdb-dump-toc' does not read the config file because it is using a TocHandler construction that does not require access to the configuration. How the tool no longer shows the config option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution to expose a C-API and serve it via cffi to python is nice, although tedious, e.g. manual labor intense, solution. Due to C++ and Python being object oriented, the function/procedural C-API is a bit more verbose than wished. This leads to additional overhead when exposing new functionality, likewise when wrapping functional constructs.
This MR proposes the use of pybind11 to have a more convenient and expressive way of writing the transition layer between the C++ and Python-API.
This is WIP. I added a
fdb_py.ccfile containing all definitions for the C++-Python-Interaction, added the creation of the shared object file to CMake and added a pyproject.toml.