Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimise #29

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Feature/optimise #29

merged 6 commits into from
Nov 13, 2024

Conversation

ChrisspyB
Copy link
Member

WIP.

Main changes so far

  • Keep input request as strings, and only convert to mars requests when deeper in the code. This is to avoid expensive (de)serialisation of polytope's many mars requests
  • Change how we support flattening of requests: It is up to the tools / pygribjump to flatten any mars requests from the user. The gribjump C++ API will assume the requests are already flattened.

May wish to revisit this down the line.

@ChrisspyB
Copy link
Member Author

todo before merge:

  • Squash debugging commits
  • Remove unused experimental serialisation code

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 77.85235% with 33 lines in your changes missing coverage. Please review.

Project coverage is 61.66%. Comparing base (98beec3) to head (14e3372).

Files with missing lines Patch % Lines
src/gribjump/Lister.cc 53.84% 6 Missing ⚠️
src/gribjump/info/InfoCache.cc 33.33% 6 Missing ⚠️
src/gribjump/gribjump_c.cc 0.00% 4 Missing ⚠️
src/gribjump/Engine.cc 94.11% 3 Missing ⚠️
src/gribjump/tools/ToolUtils.cc 82.35% 3 Missing ⚠️
src/gribjump/GribJumpException.h 0.00% 2 Missing ⚠️
src/gribjump/LocalGribJump.cc 66.66% 2 Missing ⚠️
src/gribjump/remote/RemoteGribJump.cc 33.33% 2 Missing ⚠️
src/gribjump/remote/Request.cc 0.00% 2 Missing ⚠️
src/gribjump/ExtractionData.cc 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #29      +/-   ##
===========================================
- Coverage    62.05%   61.66%   -0.40%     
===========================================
  Files           85       85              
  Lines         4420     4356      -64     
  Branches       485      484       -1     
===========================================
- Hits          2743     2686      -57     
+ Misses        1677     1670       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB
Copy link
Member Author

Just need to test lazy jumpinfo enable/disable works as expected.

@ChrisspyB ChrisspyB merged commit da1ba0a into develop Nov 13, 2024
101 of 102 checks passed
@ChrisspyB ChrisspyB deleted the feature/optimise branch November 29, 2024 13:29
@ChrisspyB ChrisspyB restored the feature/optimise branch November 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants