Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRUCache per field, not per file #30

Merged
merged 2 commits into from
Nov 26, 2024
Merged

LRUCache per field, not per file #30

merged 2 commits into from
Nov 26, 2024

Conversation

ChrisspyB
Copy link
Member

@ChrisspyB ChrisspyB commented Nov 15, 2024

A slightly more sensible cache. Quite a big change which affects plugin and server so:

  • Test at scale with large/small cache on server, make sure it works
  • Also check timings, the cache is now more fine grained so more time will be spent twiddling with it. Make sure this isn't now a bottleneck.
  • Check memory footprint. In principle we should be able to make it quite large since jumpinfo objects tend not to be too big, though depends on packing (ccsds)

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 88.18182% with 13 lines in your changes missing coverage. Please review.

Project coverage is 62.01%. Comparing base (ded3024) to head (0c24792).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/gribjump/info/InfoCache.cc 89.10% 11 Missing ⚠️
src/tools/gribjump-dump-info.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
+ Coverage    61.77%   62.01%   +0.23%     
===========================================
  Files           85       85              
  Lines         4440     4454      +14     
  Branches       488      492       +4     
===========================================
+ Hits          2743     2762      +19     
+ Misses        1697     1692       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisspyB
Copy link
Member Author

Consider a indexfile.load(offsets) option, which is like load but returns early if it has everything it needs.

@ChrisspyB ChrisspyB marked this pull request as ready for review November 25, 2024 10:33
@ChrisspyB ChrisspyB merged commit be8752e into develop Nov 26, 2024
102 checks passed
@ChrisspyB ChrisspyB deleted the feature/better-cache branch November 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants