Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/config params #5

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feature/config params #5

wants to merge 3 commits into from

Conversation

antons-it
Copy link
Collaborator

Enable plugins to request parameters from config file
Note: Do not merge yet, PR is currently for discussion only

@FussyDuck
Copy link

FussyDuck commented Feb 18, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.32653% with 123 lines in your changes missing coverage. Please review.

Project coverage is 35.18%. Comparing base (0355966) to head (e7704f7).

Files with missing lines Patch % Lines
examples/example3.F90 0.00% 38 Missing ⚠️
examples/example2.cc 0.00% 21 Missing ⚠️
examples/example1.F90 0.00% 9 Missing ⚠️
examples/example1.cc 0.00% 9 Missing ⚠️
examples/example3.cc 0.00% 9 Missing ⚠️
src/plume/Manager.cc 62.50% 9 Missing ⚠️
src/plume/data/ModelData.cc 0.00% 8 Missing ⚠️
examples/example2.F90 0.00% 7 Missing ⚠️
examples/plugin_bar.cc 0.00% 6 Missing ⚠️
src/plume/PluginHandler.cc 69.23% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #5      +/-   ##
===========================================
- Coverage    36.59%   35.18%   -1.42%     
===========================================
  Files           44       45       +1     
  Lines         1585     1694     +109     
  Branches        67       77      +10     
===========================================
+ Hits           580      596      +16     
- Misses        1005     1098      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants