fix: prevent saving "undefined" tracking code on tag creation

ecomplus · Sep 17, 2024 · ccb6fd5 · ccb6fd5
1 parent 493c215
commit ccb6fd5
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/functions/routes/ecom/webhook.js b/functions/routes/ecom/webhook.js
@@ -47,18 +47,21 @@ exports.post = ({ appSdk }, req, res) => {
             logger.info(`Start creating tag for #${storeId} ${orderId}`)
             const data = await createTag(order, storeId, appData, appSdk)
             logger.info(`Tag created for #${storeId} ${orderId}`, { data })
-            trackingCodes.push({
-              code: String(data['@id'] || data.id),
-              link: 'https://www.freteclick.com.br/rastreamento',
-              tag: 'freteclick'
-            })
-            await appSdk.apiRequest(
-              storeId,
-              `/orders/${orderId}/shipping_lines/${shippingLine._id}.json`,
-              'PATCH',
-              { tracking_codes: trackingCodes },
-              auth
-            )
+            const trackingId = data['@id'] || data.id
+            if (trackingId) {
+              trackingCodes.push({
+                code: String(trackingId),
+                link: 'https://www.freteclick.com.br/rastreamento',
+                tag: 'freteclick'
+              })
+              await appSdk.apiRequest(
+                storeId,
+                `/orders/${orderId}/shipping_lines/${shippingLine._id}.json`,
+                'PATCH',
+                { tracking_codes: trackingCodes },
+                auth
+              )
+            }
           }
         }
       }