Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add stable points for PortfolioConsumerType #1259

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alanlujan91
Copy link
Member

This is inheriting the way to calculate stable points from ConsIndShock, which might not be appropriate for PortfolioConsumerType but provides a starting point.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@alanlujan91 alanlujan91 requested a review from sbenthall April 20, 2023 13:59
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (09f1843) 72.55% compared to head (72e0018) 72.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
+ Coverage   72.55%   72.59%   +0.04%     
==========================================
  Files          78       78              
  Lines       13009    13028      +19     
==========================================
+ Hits         9439     9458      +19     
  Misses       3570     3570              
Impacted Files Coverage Δ
HARK/ConsumptionSaving/ConsPortfolioModel.py 90.23% <100.00%> (+0.41%) ⬆️
HARK/ConsumptionSaving/ConsRiskyAssetModel.py 44.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@llorracc
Copy link
Collaborator

Alan,

Seb has a PR to the LucasAssetPrice that has a formula that, if it is correct, should be the right impatience condition for the portfolio choice model (when the risky return from the standpoint of the portfolio choice consumer is the portfolio-weighted return). I don’t have time to review Seb’s PR right now — I did the derivations for the approximate formula, which were what was needed for the pedagogical purpose of the handout, and Seb has tried to turn that into the exact formula in levels (that’s what his PR does). If you could review that, then incorporate that formula into the PortfolioConsumerType model (with a comment linking to the LAP lecture notes as the justification), that would be great.

cc’ing Akshay because I’ve mentioned to him that this would be a useful small extension to the derivations in the BufferStockTheory paper that he is reviewing for me. Presumably the condition in my LAP model is identical to impatience formulas in Stachurski, Ma, and Toda (if I am right that their model is one with only rate-of-return risk).

PS. I've added all three of you as collaborators, so that Alan can merge Seb's PR after review.

@alanlujan91 alanlujan91 changed the title Add stable points for PortfolioConsumerType [WIP] Add stable points for PortfolioConsumerType Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute mNrmStE for the PortfolioConsumerType Set starting aNrm for Lucas population near equilibrium
2 participants