Distribution updates #1323
Distribution updates #1323
Conversation
random seed now returns a seed generated from the RNG of this distribution
discretize only applies to continuous distributions
return DiscreteDistribution if sigma = 0 add endpoint options use `random_seed`
clean up code and add endpoints
HARK.distribution.random_seed() generates a seed from entropy the class method random_seed generates a seed from distribution RNG
|
Do not merge until #1306 is merged |
|
Hey, #1306 is pending on the whole "what should happen when we pass different things to If you want me to merge that in and postpone that conversation to let this advance, happy to do it. |
|
5 tests fail, which isn't drastic, will test what happens if I set seeds to 0 |
|
Only 3 tests fail when changing the way default and random seeds work throughout HARK in a way that is recommended by folks at scipy. See This PR allows us to use simple seeds when we must (seed = 0) and "good" pseudorandom seeds when we need. |
|
Of the failing tests, one is of a simulation output. But a couple are testing the output of the
|
Please ensure your pull request adheres to the following guidelines: