Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write the installation guide #1350

Closed
wants to merge 3 commits into from

Conversation

AA-Turner
Copy link
Collaborator

@AA-Turner AA-Turner commented Sep 20, 2023

This PR re-writes the installation guide for new users:

  • Split contributing to the contributing guide to avoid duplicating content
  • Reccomend PyCharm or VS Code over the end-of-life Atom
  • Reccomend always using a venv, as best practice
  • Remove the duplicated Anaconda vs pip sections -- pip install works on both
  • Remove references to Python 2
  • Use named markdown links for line-length

A

cc: @MridulS, @DominicWC

@MridulS
Copy link
Member

MridulS commented Sep 22, 2023

Reccomend always using a venv, as best practice

Just a personal preference, but for econ-ark we should really be recommending conda/mamba. Especially because it also takes care of python installations, no one should be fighting around with setting PATH. We also have in the past run into cases where there were no pypi wheels available for one of our dependencies, and conda-forge did have a proper built package.

@llorracc
Copy link
Collaborator

llorracc commented Sep 23, 2023 via email

@AA-Turner
Copy link
Collaborator Author

recommending conda/mamba

Brill, I'll rewrite. Do you want to keep the reccomendation of the Anaconda Distribution, or just prefer conda-forge instead?

a

@sidd3888
Copy link
Collaborator

sidd3888 commented Oct 7, 2023

@MridulS on the point of using conda-forge vs pip, I was just testing two instances of the HARK package: one in a conda env and another in a PyPI virtualenv. The first instance was installed using conda-forge and the second using pip, and I noticed some inconsistencies between the two. For instance, the function CRRAutility() is available in the HARK.utilities module in the conda-forge installation. However, it has been moved to the HARK.rewards module in the pip version. Per the current API reference documentation, the function should be in HARK.rewards.

The two screenshots below show what I am referring to:

Anaconda

Screenshot 2023-10-07 163048

pip

Screenshot 2023-10-07 164200

Since the function CRRAutility() is among the first ones used in the ARKitecture documentation, it may hinder the process of becoming familiar with HARK for new users, say like me.

EDIT: I realized that the problem is an incompatibility with Python 3.11, which does not allow the installation of the latest version of HARK using conda-forge. Then, the older versions of HARK try to import time.clock(), which the new Python does not have. This might be an issue to look into, though you can ignore the previous bits.

@llorracc
Copy link
Collaborator

llorracc commented Oct 8, 2023 via email

@sidd3888
Copy link
Collaborator

sidd3888 commented Mar 13, 2024

Having looked at the installation guide and the quick-start guide, both in their current forms seem to be nearly identical. The only case in which it makes sense to retain the two is if we change the installation guide to contain instructions to install econ-ark via both pip and conda-forge. Else, we might as well remove one.

@AA-Turner @alanlujan91 thoughts?

@sidd3888 sidd3888 closed this Apr 18, 2024
@llorracc
Copy link
Collaborator

Sid,

I see you've closed this. Your point seems a good one. Did it get incorporated or have you just given up?

@sidd3888
Copy link
Collaborator

I still stand by the idea that we should remove the installation guide. The contents were the same as the quick start guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants