-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linting action to run pre-commit #1357
Conversation
0d8c7f9 is the action file. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
=======================================
Coverage 73.02% 73.02%
=======================================
Files 79 79
Lines 13377 13377
=======================================
Hits 9769 9769
Misses 3608 3608
☔ View full report in Codecov by Sentry. |
@alanlujan91 ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
This PR, add a new action which will run pre-commit on every PR. This should address #1340
I have also run pre-commit all across the code.
This PR also moves to start using
ruff
but just for notebooks right now. I have removed the jupytext pre-commit hook.