Update PerfForesightConsumerType

[sidd3888]

Made some fixes in the language and description of the model and the code. One mistake left to be clarified.

Paragraph in the subsection Example parameter values to construct an instance of PerfForesightConsumerType that elaborates, "In contrast, we could specify a life-cycle model...", which states that the parameter T_cycle could be set to $1$. However, it is already set to $1$ and this would not allow room for age-varying parameters of income growth and survival probability.

Ready to merge in all other aspects.

CC: @alanlujan91

[mnwhite]

Ah, that should say "cycles", not "T_cycle". I'll look at that comment; we don't want misleading or false information in docstrings.

…

On Fri, Nov 10, 2023 at 1:35 PM Siddarth Venkatesh ***@***.***> wrote: Made some fixes in the language and description of the model and the code. One mistake left to be clarified. Paragraph in the subsection *Example parameter values to construct an instance of PerfForesightConsumerType* that elaborates, "In contrast, we could specify a life-cycle model...", which states that the parameter T_cycle could be set to $1$. However, it is already set to $1$ and this would not allow room for age-varying parameters of income growth and survival probability. Ready to merge in all other aspects. ------------------------------ You can view, comment on, or merge this pull request online at: #1358 Commit Summary - c70ebc9 <c70ebc9> Update PerfForesightConsumerType.ipynb File Changes (1 file <https://github.com/econ-ark/HARK/pull/1358/files>) - *M* examples/ConsIndShockModel/PerfForesightConsumerType.ipynb <https://github.com/econ-ark/HARK/pull/1358/files#diff-9d66369772ee85955dcef8ed98feb176516db8bfab21a53cddd62060909394c1> (128) Patch Links: - https://github.com/econ-ark/HARK/pull/1358.patch - https://github.com/econ-ark/HARK/pull/1358.diff — Reply to this email directly, view it on GitHub <#1358>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKRAFOS3PHILJDCJHEE6XDYDZXV7AVCNFSM6AAAAAA7GR3OYKVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DQMJVG44DOMY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ec3404) 73.02% compared to head (c70ebc9) 73.02%.
Report is 8 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1358   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          79       79           
  Lines       13377    13377           
=======================================
  Hits         9769     9769           
  Misses       3608     3608           

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sidd3888]

@mnwhite The thing I pointed out, and you were looking into, is still pending to be resolved. Will open a new PR to resolve that once these stylistic issues have been decided upon. Thanks.