Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for v0.14.0 release #1377

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Preparation for v0.14.0 release #1377

merged 7 commits into from
Feb 12, 2024

Conversation

mnwhite
Copy link
Contributor

@mnwhite mnwhite commented Feb 1, 2024

Update CHANGELOG, init, pyproject.

Update CHANGELOG, init, pyproject.
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (497de72) 71.59% compared to head (1549c6b) 71.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1377   +/-   ##
=======================================
  Coverage   71.59%   71.59%           
=======================================
  Files          84       84           
  Lines       13933    13933           
=======================================
  Hits         9975     9975           
  Misses       3958     3958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnwhite
Copy link
Contributor Author

mnwhite commented Feb 1, 2024

Bumping version numbers caused a lot of tests to fail. Really not sure what this means.

@alanlujan91
Copy link
Member

alanlujan91 commented Feb 1, 2024

@mnwhite not your fault, something with numba was failing as of last night

https://github.com/econ-ark/HARK/actions/runs/7734162741

which seems to flow from dependency issues in interpolation.py

Test whether pyproject version number was the issue.
@mnwhite
Copy link
Contributor Author

mnwhite commented Feb 1, 2024

Whoops @alanlujan91 , I didn't notice your comment before pushing a test rollback. Because things were working on Tuesday and not working today, I assumed it was the version number change. I guess I'll let things stew for a day or two and see if it resolves itself.

@llorracc
Copy link
Collaborator

llorracc commented Feb 5, 2024 via email

Testing whether tests are working again.
@mnwhite
Copy link
Contributor Author

mnwhite commented Feb 5, 2024

@llorracc Something external to HARK has been changed and it's breaking our tests. Alan thinks it's interpolation.py and that we need to remove our usage / dependency on it because it's not being maintained.

@alanlujan91 alanlujan91 linked an issue Feb 7, 2024 that may be closed by this pull request
@alanlujan91
Copy link
Member

tests are starting to pass!

@mnwhite
Copy link
Contributor Author

mnwhite commented Feb 7, 2024 via email

@alanlujan91
Copy link
Member

Outstanding check failing has to do with Documentation: @MridulS @AA-Turner help?

mnwhite and others added 2 commits February 7, 2024 16:23
Merge RNG fix into v14 preparation branch
parallel writing. So let's default to 1 job for now
@alanlujan91 alanlujan91 assigned mnwhite and unassigned MridulS and AA-Turner Feb 8, 2024
@alanlujan91
Copy link
Member

@mnwhite this now passes Documentation checks, and will (hopefully) pass all other tests soon

@mnwhite mnwhite merged commit 85b81ff into master Feb 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'generated_jit' from 'numba'
5 participants