-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for v0.14.0 release #1377
Conversation
Update CHANGELOG, init, pyproject.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1377 +/- ##
=======================================
Coverage 71.59% 71.59%
=======================================
Files 84 84
Lines 13933 13933
=======================================
Hits 9975 9975
Misses 3958 3958 ☔ View full report in Codecov by Sentry. |
Bumping version numbers caused a lot of tests to fail. Really not sure what this means. |
@mnwhite not your fault, something with numba was failing as of last night https://github.com/econ-ark/HARK/actions/runs/7734162741 which seems to flow from dependency issues in interpolation.py |
Test whether pyproject version number was the issue.
Whoops @alanlujan91 , I didn't notice your comment before pushing a test rollback. Because things were working on Tuesday and not working today, I assumed it was the version number change. I guess I'll let things stew for a day or two and see if it resolves itself. |
Just checking in on the progress of this …
From: Matthew N. White ***@***.***>
Date: Thursday, February 1, 2024 at 15:13
To: econ-ark/HARK ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [econ-ark/HARK] Preparation for v0.14.0 release (PR #1377)
Whoops @alanlujan91<https://github.com/alanlujan91> , I didn't notice your comment before pushing a test rollback. Because things were working on Tuesday and not working today, I assumed it was the version number change. I guess I'll let things stew for a day or two and see if it resolves itself.
—
Reply to this email directly, view it on GitHub<#1377 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAKCK76LJI75XRUZTY457M3YRPZN7AVCNFSM6AAAAABCVPZLMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRSGE2TGNZVHA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Testing whether tests are working again.
@llorracc Something external to HARK has been changed and it's breaking our tests. Alan thinks it's interpolation.py and that we need to remove our usage / dependency on it because it's not being maintained. |
tests are starting to pass! |
Incredible!
…On Wed, Feb 7, 2024, 9:35 AM Alan Lujan ***@***.***> wrote:
tests are starting to pass!
—
Reply to this email directly, view it on GitHub
<#1377 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFIYW4NUJACHVCPRZL3YSOGLNAVCNFSM6AAAAABCVPZLMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGE3TSMZZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Outstanding check failing has to do with Documentation: @MridulS @AA-Turner help? |
Merge RNG fix into v14 preparation branch
parallel writing. So let's default to 1 job for now
@mnwhite this now passes Documentation checks, and will (hopefully) pass all other tests soon |
Update CHANGELOG, init, pyproject.