Remove metadata argument for jpg in make_figs #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not supported for this filetype, was throwing error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1386 +/- ##
==========================================
+ Coverage 71.59% 71.69% +0.09%
==========================================
Files 84 84
Lines 13933 13939 +6
==========================================
+ Hits 9975 9993 +18
+ Misses 3958 3946 -12 ☔ View full report in Codecov by Sentry. |
I hate lint or black or whatever it is. PRs should not fail due to a missing space after a #.
|
@alanlujan91 This is a one line bugfix that Chris wanted for #1375 , turning off an illegal argument for jpg in make_figs. He wants a minor release for this (for HAFiscal, I think), so I'm going to do one more little thing (repr behavior for IndShockConsumerType) and then release 0.14.1. Review/merge when you have time. |
alanlujan91
approved these changes
Feb 20, 2024
|
Let me see if I can add a quick test after I grab lunch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata argument was not supported for this filetype, was throwing error. CDC wants a minor release for this. I'm going to put in one more annoying behavior fix before I do that.