Add more parameter types to Parameters

[Mv77]

I have been playing with the core.Parameters class and really like it. One limitation is that it restricts the class of parameters that can be time-varying. This PR adds support for a few more classes: booleans, distributions, and functions.

You can imagine passing time-varying parameters of this class if, for instance you want:

• To indicate whether an agent is retired = True | False for some meaningful change in its income process.
• To have a time varying distribution for income shocks. Maybe this period they are normal, and the next they are lognormal.
• To have a time varying tax function.

I have used this class in my ongoing work and have been very happy with it.

• Tests for new functionality/models or Tests to reproduce the bug-fix in code.
• Updated documentation of features that add new functionality.
• Update CHANGELOG.md with major/minor changes.

[Mv77]

@alanlujan91 should this change be reflected in other parts of the code like, say,

HARK/HARK/core.py

Line 95 in 6a73c4f

self._parameters: Dict[str, Union[int, float, np.ndarray, list, tuple]] = {}

?

[Mv77]

Not sure this needs a test?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.69%. Comparing base (bbb07a5) to head (7417c54).

❗ Current head 7417c54 differs from pull request most recent head 8fb9040. Consider uploading reports for the commit 8fb9040 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   71.53%   71.69%   +0.15%     
==========================================
  Files          83       84       +1     
  Lines       13938    13939       +1     
==========================================
+ Hits         9971     9993      +22     
+ Misses       3967     3946      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alanlujan91]

@MridulS is there a way for pre-commit to automatically upload changes?

[MridulS]

There is pre-commit.ci but it makes changes to the PR branch and you need to make sure the contributors are pulling in all changes before making any new changes locally. I would just strongly suggest to new contributors to use pre-commit locally :)

[alanlujan91]

well, somehow my pre-commit is different than the one in github actions?? @MridulS

[Mv77]

MAC hates me. And I hate it too.
It's the same tests as in #1415

Will come back to this when that's merged

[sbenthall]

This PR was blocked by some unrelated logistical thing.
Now its only conflict is the CHANGELOG.

Can this be fixed and merged now?

[mnwhite]

I'll try to look at this in the morning. I thought it still had a (non-trivial) outstanding issue.

…

On Tue, Jun 25, 2024, 7:38 PM Sebastian Benthall ***@***.***> wrote: This PR was blocked by some unrelated logistical thing. Now its only conflict is the CHANGELOG. Can this be fixed and merged now? — Reply to this email directly, view it on GitHub <#1387 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKRAFPECECNYOSMUO6NPCLZJH5QVAVCNFSM6AAAAABDV3AKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGIYDOMZUHE> . You are receiving this because your review was requested.Message ID: ***@***.***>

[mnwhite]

GitHub is hanging on its automatic merge check. I'm trying to get this in now.