Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: update deps #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f88cf1
chore: update deps
Kelwan Jun 20, 2024
88fe2a0
fix: adjust module rlocation path
zaucy Jun 20, 2024
403bb8c
fix: attempt to use my rules_rust patch
zaucy Jun 20, 2024
ab9534f
chore: fix remote
zaucy Jun 20, 2024
b685fab
chore: remove repin for windows
zaucy Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
[workspace]
resolver = "2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this fixed it?

members = [
"ecsact",
"ecsact_dylib_runtime",
"ecsact_env",
"ecsact_macro",
"ecsact_rtb",
"ecsact_rust_codegen",
"ecsact_system_execution_context",
"example",
"ecsact",
"ecsact_dylib_runtime",
"ecsact_env",
"ecsact_macro",
"ecsact_rtb",
"ecsact_rust_codegen",
"ecsact_system_execution_context",
"example",
]

1 change: 0 additions & 1 deletion ecsact_dylib_runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ ecsact = { path = "../ecsact", version = "0.1.0" }
bindgen = "0.63.0"
cc = "1.0.78"
json = "0.12.4"

2 changes: 1 addition & 1 deletion ecsact_dylib_runtime/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ fn ecsact_include_dir() -> String {
if rt_headers.is_ok() {
let runfiles = Runfiles::create().unwrap();
let header = runfiles
.rlocation("ecsact_runtime/ecsact/runtime.h")
.rlocation("ecsact_runtime~/ecsact/runtime.h")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was the main issue for me

.into_os_string()
.into_string()
.unwrap()
Expand Down
2 changes: 0 additions & 2 deletions ecsact_dylib_runtime/src/dylib_wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#define ECSACT_META_API

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I'm not sure why I put this here before 🤔

#define ECSACT_ASYNC_API_LOAD_AT_RUNTIME
#define ECSACT_CORE_API_LOAD_AT_RUNTIME
#define ECSACT_DYNAMIC_API_LOAD_AT_RUNTIME
Expand Down
1 change: 0 additions & 1 deletion ecsact_system_execution_context/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ ecsact = { path = "../ecsact" }
[build-dependencies]
bindgen = "0.63.0"
json = "0.12.4"

Loading