Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.0 #2

Merged
merged 59 commits into from
Nov 20, 2024
Merged

v0.1.0 #2

merged 59 commits into from
Nov 20, 2024

Conversation

stefanunrein
Copy link
Collaborator

@stefanunrein stefanunrein commented Dec 29, 2021

New Features

  • Uploaded a tool to select a matching Xilinx Vivado version based on the XPR file version/version of the referenced Vivado edition.
  • Added PyCharm project files and settings.

Changes

  • Removed "Work in Progress" banner.
  • Allow *.cmd and *.ico files in /dist/...
  • Added contributors and license section to README.
  • ci/Params: override python_version_list, since 3.6 was deprecated in pyTooling/Actions.
  • doc: update Codacy shields.

Bug Fixes

None

Related PRs


/cc @umarcor

@Paebbels
Copy link
Member

Paebbels commented Dec 30, 2021

TODOs

  • Add a Windows based CI job to build the executable via pyInstaller (@Paebbels).
  • Add a CI job to publish that executable to GitHub releases (@umarcor).
  • Fill section "Main Goals" in README (@stefanunrein).
  • Fill section "Installation / Usage" in README (@stefanunrein).

@Paebbels Paebbels requested a review from umarcor December 30, 2021 01:54
@@ -0,0 +1 @@
pyinstaller -F -n VivadoLauncher.exe --icon=vivado_logo.ico --clean --distpath=. --workpath=./temp ../pyEDAA/Launcher/__init__.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, generating an executable with the Python entrypoint is out of the scope.
I would prefer if the README and/or the docs were updated first, in order to explain what is the expected purpose and scope of this repository.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we/ Should we upload a local build executable until the pipe is working for automatic builds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lately we did updates to the pipeline, so it can run also on macOS, Windows and MinGW64. So we can now start to write the job for it.

labels:
- Dependencies
assignees:
- Paebbels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to assign all these PRs to yourself by default?

reviewers:
- Paebbels
schedule:
interval: daily
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typically prefer to set it weekly, in order to reduce the traffic/noise in the repos. That way, you get all the PRs created the same day at the same time.

@umarcor umarcor added the Enhancement New feature or request label Dec 30, 2021
.btd.yml Outdated
@@ -5,4 +5,5 @@ target: gh-pages
formats: [ html ]
images:
base: btdi/sphinx:pytooling
latex: btdi/latex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not building the PDF, this is not necessary.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@11276a1). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   43.20%           
=======================================
  Files           ?        1           
  Lines           ?       81           
  Branches        ?       16           
=======================================
  Hits            ?       35           
  Misses          ?       43           
  Partials        ?        3           
Flag Coverage Δ
unittests 43.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Paebbels Paebbels marked this pull request as ready for review November 20, 2024 00:05
@Paebbels Paebbels merged commit 8b72cf9 into main Nov 20, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants