-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.1.0 #2
Conversation
TODOs
|
@@ -0,0 +1 @@ | |||
pyinstaller -F -n VivadoLauncher.exe --icon=vivado_logo.ico --clean --distpath=. --workpath=./temp ../pyEDAA/Launcher/__init__.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, generating an executable with the Python entrypoint is out of the scope.
I would prefer if the README and/or the docs were updated first, in order to explain what is the expected purpose and scope of this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we/ Should we upload a local build executable until the pipe is working for automatic builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lately we did updates to the pipeline, so it can run also on macOS, Windows and MinGW64. So we can now start to write the job for it.
.github/dependabot.yml
Outdated
labels: | ||
- Dependencies | ||
assignees: | ||
- Paebbels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to assign all these PRs to yourself by default?
.github/dependabot.yml
Outdated
reviewers: | ||
- Paebbels | ||
schedule: | ||
interval: daily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I typically prefer to set it weekly, in order to reduce the traffic/noise in the repos. That way, you get all the PRs created the same day at the same time.
.btd.yml
Outdated
@@ -5,4 +5,5 @@ target: gh-pages | |||
formats: [ html ] | |||
images: | |||
base: btdi/sphinx:pytooling | |||
latex: btdi/latex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not building the PDF, this is not necessary.
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
=======================================
Coverage ? 43.20%
=======================================
Files ? 1
Lines ? 81
Branches ? 16
=======================================
Hits ? 35
Misses ? 43
Partials ? 3
Flags with carried forward coverage won't be shown. Click here to find out more. |
New Features
Changes
*.cmd
and*.ico
files in/dist/...
Bug Fixes
None
Related PRs
/cc @umarcor