Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Include Contacts and Parents data in parent tables due to Ed-Fi rename #142

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sleblanc23
Copy link
Contributor

@sleblanc23 sleblanc23 commented Jul 22, 2024

Description & motivation

In Data Standard v5.0, Parents were renamed to Contacts. The new Contact entity is identical to the previous Parent entity with the addition of an optional GenderIdentity, PreferredFirstName, and PreferredLastName fields. StudentParentAssociations was also renamed to StudentContactAssociations. The goal of this PR is to get v5.0 data correctly incorporated into the model without doing the full naming shift from parents to contacts.

Note: These changes require this edu_edfi_source feature branch to be merged and released. The packages.yml file will need to be updated with this requirement.

Breaking changes introduced by this PR:

Added three new columns to dim_parent that were introduced with the change to Contacts

PR Merge Priority:

  • Medium: needed for Stadium SCDE

Changes to existing files:

  • fct_student_parent_association, bld_ef3__parent_wide_emails, and bld_ef3__parent_wide_phone_numbers : source from the contacts staging tables, rename k_contact back to k_parent
  • dim_parent : source from the contacts staging tables, rename k_contact back to k_parent, and add three new columns

Tests and QC done:

Ran in Stadium SCDE; confirmed that grain tests passed and row counts look correct.

edu_wh PR Review Checklist:

Make sure the following have been completed before approving this PR:

  • Description of changes has been added to Unreleased section of CHANGELOG.md. Add under ## New Features for features, etc.
  • If a new configuration xwalk was added:
    • The code is written such that the xwalk is optional (preferred), and this behavior was tested, OR
    • The code is written such that the xwalk is required, and the required xwalk is added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new xwalk has been added to EDU documentation site here
  • If a new configuration variable was added:
    • The code is written such that the variable is optional (preferred), and this behavior was tested, OR
    • The code is written such that the variable is required, and a default value was added to edu_project_template, and this PR is flagged as breaking change (not for patch release)
    • A description for the new variable has been added to EDU documentation site here
  • Reviewer confirms the grain of all tables are unchanged, OR any changes are expected, communicated, and this PR is flagged as a breaking change (not for patch release)

Future ToDos & Questions:

We probably want to do a breaking change that completes the rename from Parents to Contacts here and in downstream systems. See the Slite doc for notes on what would be affected and how we might do this (configurable aliasing, etc.)

@sleblanc23 sleblanc23 marked this pull request as ready for review July 22, 2024 21:10
@sleblanc23 sleblanc23 marked this pull request as draft August 5, 2024 14:20
@sleblanc23 sleblanc23 marked this pull request as ready for review September 5, 2024 17:59
@rlittle08
Copy link
Collaborator

@sleblanc23 please remove the edit to packages.yml, then this is ready to be approved

@sleblanc23
Copy link
Contributor Author

@rlittle08 done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants