Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect_non_report_files: use 0 instead of None for no coverage #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 16, 2017

Otherwise it shows up as 100% covered in Coveralls.

@blueyed
Copy link
Contributor Author

blueyed commented Aug 16, 2017

Not verified if this fixes it really, but it is likely.

@chrisosaurus
Copy link
Collaborator

Not verified?

You should be able to test this yourself before we merge it.

@chrisosaurus
Copy link
Collaborator

The json format for coveralls.io uses both 'null' and '0'
http://docs.coveralls.io/api-reference

0 if the line is not covered by the test suite.
null to indicate the line is not relevant to code coverage (it may be whitespace or a comment).

can you please indicate which files you had which were incorrectly showing up as 100% coverage?

@blueyed
Copy link
Contributor Author

blueyed commented Jul 8, 2018

@mkfifo
If I remeber this was with awesomeWM/awesome, but it also ~1 year old.

IIRC it is like documented: 0 means not covered and None means not relevant for coverage.
And from looking at the code quickly it looks like the files there are not covered (it skips non-sourced files etc).

Anyway, I am using codecov.io and Python mainly anywany - feel free to close it.

Otherwise it shows up as 100% covered in Coveralls.
@blueyed blueyed force-pushed the collect_non_report_files-0-for-none branch from 094ba80 to 0104dbb Compare February 18, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants